Comments on: MP3 player from Yahoo! - bookmarklet

by: Когато оловният дирижабъл е тъжен | Блогът на Гонзо

Thu, 20 Mar 2008 20:08:29 +0000

[…] Благодаря на Стоян, че ме открехна за Yahoo! Media Player, благодарение на който можете да слушате парчетата без изрично да ги теглите. […]

by: Stoyan

Tue, 26 Feb 2008 01:51:53 +0000

np, Paul, thank you for keeping aurgasm.us up

by: Paul Irish

Sun, 24 Feb 2008 01:20:58 +0000

Stoyan, thanks for throwing together that bookmarklet. It's very useful.

by: phpied.com » Blog Archive » Audacity + Starcaster

Thu, 31 Jan 2008 23:30:45 +0000

[...] Ah, yeah and the nice player you use to hear these MP3s is the Yahoo! Media Player, which you can integrate on every page. Post this entry to: » del.icio.us » Digg » Furl » Newsvine » reddit » Y! [...]

by: Carl

Tue, 29 Jan 2008 16:49:27 +0000

By the way…

Change line:
e.onreadystatechange=function(){if(this.readyState=="complete"){c();}}

to:
e.onreadystatechange=function(){if(this.readyState=="complete"){c();e=null;}}

This will prevent a memory leak in IE6 due to a bug in IE memory management (which is fixed in IE7).

by: Carl

Tue, 29 Jan 2008 01:29:55 +0000

Sure. Feel free to incorporate my code. No charge Thanks for posting the bookmarklet!

by: Stoyan

Sat, 26 Jan 2008 11:20:58 +0000

Thanks Carl, this is much better, definitely! 100ms delay was one of those works-for-me quickies which no self-respecting developer should post publicly
I'll update my post with your permission to use your code.

by: Carl

Fri, 25 Jan 2008 20:10:36 +0000

As noted, you could improve the code by actually waiting for the script to load instead of guessing that it will be there in 100ms.

javascript:(function(){
function c(){
YAHOO.music.WebPlayer.asyncLoadPlayer();
}
var e=document.createElement("script");
if(e.addEventListener){
e.addEventListener("load",c,false);
}
else{
e.onreadystatechange=function(){if(this.readyState=="complete"){c();}}
}
e.type="text/javascript";
e.src="http://mediaplayer.yahoo.com/js";
document.getElementsByTagName("head")[0].appendChild(e);
})();

by: foo

Wed, 23 Jan 2008 12:32:11 +0000

this runs without an error, but it does nothing:

javascript:(function(){var script = document.createElement('script');script.src = 'http://mediaplayer.yahoo.com/now';document.getElementsByTagName('head')[0].appendChild(script);setTimeout('function(){YAHOO.music.WebPlayer.asyncLoadPlayer();}', 1000);})()

btw. better use "http://mediaplayer.yahoo.com/now" as script source

by: Stoyan

Wed, 23 Jan 2008 10:58:45 +0000

foo, this is probably because the script is not yet loaded (note to self: should've done a better job testing if the script is loaded).

You can just run it again after you give it a second or so to load.