Comments on: Better time input

By: Toby Ho

Toby Ho — Fri, 04 Nov 2011 14:52:28 +0000

What is the license on this? Can I use it for commercial projects?

By: Aaron

Aaron — Fri, 01 Jul 2011 20:32:03 +0000

Probably not that important, but the fact that 1PM turns to 1:00 AM is really annoying. So I added ‘i’ after all the ‘re:’s to ignore case. You may want to include that in the original.

For example
Before:
re: /(\d{1,2})(?:p| p)/,
After:
re: /(\d{1,2})(?:p| p)/i,

Much better, especially if you accidentally hit CAPS LOCK

By: Jon

Jon — Wed, 22 Jun 2011 20:20:22 +0000

Added two more parsing patterns:

// Noon
{ re: /^noon/i,
example: new Array(‘noon’),
handler: function() {
var d = new Date();
d.setHours(12);
d.setMinutes(0);
d.setSeconds(0);
return d;
}
},
// Midnight
{ re: /^midnight/i,
example: new Array(‘midnight’),
handler: function() {
var d = new Date();
d.setHours(0);
d.setMinutes(0);
d.setSeconds(0);
return d;
}
},

By: mltsy

mltsy — Wed, 08 Dec 2010 00:57:30 +0000

Here is a fixed script – I’ve adjusted getReadable to be a user-friendly representation for my purpose (i.e. “1:30 PM”)

And more importantly, the following inputs have been fixed by updating the timeParsePatterns, and adding a ‘get_hours” function:
1230am => 12:30 AM
130 => 1:30 AM

I’ve also added a “pm_default” option in case you want the default to be pm rather than am – here it is: http://pastie.org/1357481

I should mention that I made a couple modifications to the “magicTime” function itself that use jQuery and made it have a return value. If these don’t work for you, you can copy the original magicTime function, and it should work fine.

And if you do that, but you still want the default_pm option, it’s as simple as adding it to the parameter list of the function (pastie line 175), and tacking it on to the end of the call to parseTimeString (pastie line 178). It just has to be passed through.

By: patricia

patricia — Tue, 29 Jun 2010 19:26:05 +0000

Hello,
great work, this is going to be super useful, but…

i think i found a possible bug!

it can’t seem to tell the difference between am and pm when the hour is 12.

for example:

unexpected results:
when i pass: 12:19am
i get: Tue Jun 29 2010 12:19:00 GMT-0400 (Eastern Daylight Time)
and when i pass:12:19pm
i get: Tue Jun 29 2010 12:19:00 GMT-0400 (Eastern Daylight Time)

expected results:
but when i pass:01:19pm
i get:Tue Jun 29 2010 13:19:00 GMT-0400 (Eastern Daylight Time)
and when i pass:01:19am
i get:Tue Jun 29 2010 01:19:00 GMT-0400 (Eastern Daylight Time)

the behaviour can be duplicated here:
http://www.phpied.com/files/time-parser/time-parser.htm

By: Dr8k

Dr8k — Thu, 30 Oct 2008 05:43:22 +0000

Hey, great work on the script. I was looking for something like this but also implement the jQuery library (www.jquery.com) for other UI elements. I’ve updated your code to work as a jQuery plug in. If you want a copy of that drop me an email.

NB: The conversion is just a basic wrapper at this stage. I’d like to see it with output formatting options etc, but for now it just defaults to 24hour clock.

By: Tim

Tim — Tue, 27 May 2008 19:09:37 +0000

Awesome script, it was _just_ what I was looking for!! Thank you!

@Mendrik, there is one like that, I saw it just the other day. Google JQUERY + Calendar popup

By: Mendrik

Mendrik — Sun, 30 Mar 2008 20:02:43 +0000

I wish someone would combine that with a calendar picker next to it, but where the icon is actually draggable. x-axis modifies the day, y-axis the months / year.
That way people could just click and drag to the right while the input field would indicate “next wednesday” “next thursday” until the day is so far off that it would just switch to numeric formats again.

By: XavierKGB

XavierKGB — Thu, 03 May 2007 18:56:40 +0000

If your initial text box has a style class applied and after submit the style is cleared, I found you can add that style name to the javascript on line 195:

input.className = ‘YOUR-CLASS-HERE’;

Thanks for the great script!

By: Stoyan

Stoyan — Thu, 05 Apr 2007 23:36:01 +0000

Twan, that’s gotta be because the parser considers 83 as hour and 0 as minutes. If you do 0830, then it’s fine. But, yeah, it’ll be better if it figures out 8:30 and not 11.

Thanks for the input!